Write updated docs and port SEP-2663 content#2
Merged
LucaButBoring merged 21 commits intoMay 22, 2026
Conversation
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
| ``` | ||
|
|
||
| The notification includes the full task object, allowing clients to access the complete task state and final results without polling the `tasks/get` method. Clients **MAY** continue polling `tasks/get` in addition to subscribing to task status notifications, but need not do so. | ||
|
|
Contributor
There was a problem hiding this comment.
What about Progress notifications? can these also come on this stream? We could set the _meta field to include the taskId. This would preserve existing functionality and give folks a path to partial results?
Or we can omit for now and solve later. But we should add language to expressly disallow progress notifications on this stream then.
Contributor
Author
There was a problem hiding this comment.
Highlighting this one for @kurtisvg to chime in on — I think for now we should explicitly disallow this?
We actually have three options here:
- Allow progress notifications for tasks on
subscriptions/listen, which is simple to implement but inconsistent with how progress works in all other cases. This is inconsistent withsubscriptions/listenin that it imposes a disjoint requirement. - Disallow it, but continue to allow it piecemeal over SSE responses from individual
tasks/getrequests, which I've done and it's not easy, but this is also the status quo and is consistent with thesubscriptions/listenspec. - Disallow it, and also disallow it over
tasks/get: This is what I think we should do — it means progress effectively isn't usable with Tasks anymore, but leaves the door open for us to find a better home for progress information in Tasks later. This is inconsistent withsubscriptions/listenin that it is more restrictive.
I'm going to disallow it explicitly period for now, but I'm laying out the options here so we can have informed discussions about it.
edit: disallowed in a0824a2
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
CaitieM20
reviewed
May 12, 2026
Co-authored-by: Caitie McCaffrey <caitiem20@github.com>
Co-authored-by: Caitie McCaffrey <caitiem20@github.com>
Contributor
Author
|
Addressed all feedback up to this point. |
9 tasks
CaitieM20
previously approved these changes
May 22, 2026
Contributor
CaitieM20
left a comment
CaitieM20
left a comment
There was a problem hiding this comment.
LGTM - looks like the schema.json needs to be regenerated missing a couple of the notification updates.
Check mode previously compared the gitignored intermediate schema/draft/generated/schema.ts against fresh output, then wrote a temp file under that same directory to dynamic-import for JSON Schema generation. On fresh checkouts (every CI run, since schema/**/generated/ is gitignored) the directory does not exist, so the temp-file write crashed with ENOENT before reporting any real result. Local runs hid the bug because once a developer runs the generator the directory sticks around. Drop the comparison against the gitignored intermediate (it cannot be stale on CI by definition) and check only the committed schema.json. The Zod schemas file is now written unconditionally so the dynamic import resolves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writes new overview docs and ports content from modelcontextprotocol/modelcontextprotocol#2663